Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RP conventions topic update #5961

Merged
merged 1 commit into from
Apr 16, 2018
Merged

RP conventions topic update #5961

merged 1 commit into from
Apr 16, 2018

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Apr 13, 2018 •
edited
Loading

Fixes #5520

Internal Review Topic

  • I can't see the built topic, please check rendering on review.
  • I've added a note to the Sample Update Tracking Issue to add IPageHandlerModelConvention to the sample when it's upgraded to 2.1.

To speed up review of the table, the major change there (in the Model Conventions row) is

<= 2.0

  • IPageRouteModelConvention
  • IPageApplicationModelConvention

>= 2.1

  • IPageRouteModelConvention
  • IPageApplicationModelConvention
  • IPageHandlerModelConvention

@guardrex guardrex requested a review from pranavkm April 13, 2018 04:12
@guardrex guardrex merged commit ab77d22 into master Apr 16, 2018
@guardrex guardrex deleted the guardrex/rp-conventions2 branch April 16, 2018 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guardrex @pranavkm